-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable attachment of binary files as charm resources #1147
Conversation
1 similar comment
@nrobinaubertin this PR needs some kind of test. ideally an integration test, or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to more than dima.
- Please add a test that would trigger the bug if not fixed
- take care of all call site of
_upload
to ensuredata
type consistency.
Niels, I see that the PR where you needed this was closed. Do you have the bandwidth to update this PR? If not, I can maybe create an issue based on the PR and eventually someone else can pick this up. What you're fixing is basically a bug, as binary resources should be supported. |
This PR needs to be rebased since #1186 has been merged. |
I'm still using the feature but I'm using my patch locally
Not right now, so if you feel we should close this PR, we can do it and I may reopen it later.
There is already an issue, #1000 |
ccddb5e
to
d165ea5
Compare
|
d165ea5
to
c107759
Compare
c107759
to
d901c95
Compare
Moved to #1218 |
Description
This enables the attachment of binary files as charm resources.
Fixes: #1000